feat(CHAIN-3446): add signer enumeration to SystemConfigGlobal#204
Merged
leopoldjoy merged 3 commits intomainfrom Mar 11, 2026
Conversation
Collaborator
✅ Heimdall Review Status
|
roger-bai-coinbase
approved these changes
Mar 11, 2026
leopoldjoy
deleted the
leopoldjoy/chain-3446-contracts-add-signer-enumeration-to-systemconfigglobal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
getRegisteredSigners()toSystemConfigGlobal, enabling callers to read the full set of registered signers in a single view call. This is a prerequisite for the prover registrar service (CHAIN-3449), which needs to enumerate on-chain signers each poll cycle to detect orphaned entries for deregistration.Changes
EnumerableSetLib.AddressSet(already used elsewhere in the multiproof contracts)EnumerableSetLib.AddressSet internal _registeredSignersstorage (appended to end of layout — safe for upgrades)registerSigner: call_registeredSigners.add()alongside the existingsignerPCR0mapping updatederegisterSigner: call_registeredSigners.remove()alongside the existing mapping deletegetRegisteredSigners() external view returns (address[])— no event scanning required, always authoritativeDevSystemConfigGlobal.addDevSigner: also maintains the set so tests reflect production behaviour0.2.0Test plan
forge test --match-contract SystemConfigGlobalTest— 36 tests pass